From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757637AbXGARJT (ORCPT ); Sun, 1 Jul 2007 13:09:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753920AbXGARJJ (ORCPT ); Sun, 1 Jul 2007 13:09:09 -0400 Received: from x35.xmailserver.org ([64.71.152.41]:1174 "EHLO x35.xmailserver.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753822AbXGARJG (ORCPT ); Sun, 1 Jul 2007 13:09:06 -0400 X-AuthUser: davidel@xmailserver.org Date: Sun, 1 Jul 2007 10:09:04 -0700 (PDT) From: Davide Libenzi X-X-Sender: davide@alien.or.mcafeemobile.com To: Ulrich Drepper cc: Linux Kernel Mailing List , Andrew Morton , Linus Torvalds , Ingo Molnar Subject: Re: [patch 0/6] sys_indirect RFC - sys_indirect introduction In-Reply-To: Message-ID: References: X-GPG-FINGRPRINT: CFAE 5BEE FD36 F65E E640 56FE 0974 BF23 270F 474E X-GPG-PUBLIC_KEY: http://www.xmailserver.org/davidel.asc MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 1 Jul 2007, Ulrich Drepper wrote: > On 6/30/07, Davide Libenzi wrote: > > This is how all those overloaded syscalls looks like, BTW: > > [...] > > How would you do that with a single shared strcture, w/out adding in all > > signal paths the knowledge of the structure? > > You said it yourself: each individual wrapper would look like this. > Generalization really isn't possible, you'll have each wrapper syscall > looking different. This means there is no reason to try coming up > with some overly complicated data structure which would only be useful > if the processing of that data structure could be centralized. With the current API design you'd able to easily confine the "pre" code inside the "set" function, and the "post" code inside the "unset" function. It looks pretty clean to me, and allows to limit the knowledge of sys_indirect, the more as possible inside kernel/indirect.c. - Davide