From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758129AbXGCAh2 (ORCPT ); Mon, 2 Jul 2007 20:37:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756747AbXGCAhV (ORCPT ); Mon, 2 Jul 2007 20:37:21 -0400 Received: from x35.xmailserver.org ([64.71.152.41]:4187 "EHLO x35.xmailserver.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756725AbXGCAhU (ORCPT ); Mon, 2 Jul 2007 20:37:20 -0400 X-AuthUser: davidel@xmailserver.org Date: Mon, 2 Jul 2007 17:37:17 -0700 (PDT) From: Davide Libenzi X-X-Sender: davide@alien.or.mcafeemobile.com To: Ulrich Drepper cc: Linux Kernel Mailing List , Andrew Morton , Linus Torvalds , Ingo Molnar Subject: Re: [patch 0/6] sys_indirect RFC - sys_indirect introduction In-Reply-To: Message-ID: References: X-GPG-FINGRPRINT: CFAE 5BEE FD36 F65E E640 56FE 0974 BF23 270F 474E X-GPG-PUBLIC_KEY: http://www.xmailserver.org/davidel.asc MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Jul 2007, Ulrich Drepper wrote: > > But there are > > examples (and the signal stuff is one of them), where you do need the > > set_context+syscall+unset_context abstraction, for all cases where the > > kernel already has its own internal data strctures. In those cases you'd > > have to spread sys_internal context knowledge all around the kernel, > > whereas the current solution allows you to confine the code inside > > kernel/indirect.c > > Nonsense. Whether you have a new word in the task structure or a > pointer to a structure, you have to embed knowledge of this > indirection in every affected code paths. There is no difference > here. The only difference is that trying to force everything through > an artificially complicated common entry code. > > I hope that Andrew+Linus will see through this. I'm done arguing. I simply asked you to look how the code/patch would look like to handle the ppoll/pselect/epoll_pwait stuff, and precisely where your changes had to go. Or even in the exmaple Linus made of "make the fsuid/fsgid temporarily be my _real_ uid/gid for this single system call" for what it matters. - Davide