mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: technically, profile/oprofile Kconfig stuff is set up incorrectly
Date: Mon, 9 Jul 2007 07:32:03 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0707090727300.17061@localhost.localdomain> (raw)


  as a short follow up to my previous patches, it might be worth
pointing out that profiling in general is defined improperly WRT
Kconfig, since *general* profiling is defined inside the more specific
Kconfig files for *oprofiling*:

  $ ls arch/*/oprofile/Kconfig

  that makes no sense, as it leads to incorrect Kconfig files like
arch/blackfin/oprofile/Kconfig:

=============================
menu "Profiling support"
depends on EXPERIMENTAL

config PROFILING
        bool "Profiling support (EXPERIMENTAL)"
        help
          Say Y here to enable the extended profiling support mechanisms used
          by profilers such as OProfile.

config OPROFILE
        tristate "OProfile system profiling (EXPERIMENTAL)"
        depends on PROFILING
        help
          OProfile is a profiling system capable of profiling the
          whole system, include the kernel, kernel modules, libraries,
          and applications.

          If unsure, say N.

config HARDWARE_PM
        tristate "Hardware Performance Monitor Profiling"
        depends on PROFILING
        help
          take use of hardware performance monitor to profiling the kernel
          and application.

          If unsure, say N.

endmenu
==========================

where non-oprofile content (HARDWARE_PM) is now defined within the
oprofile subdirectory.

  the whole selection of profiling really should be moved up a level,
with oprofile content as a subdirectory, or something similar.

rday

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

                 reply	other threads:[~2007-07-09 11:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0707090727300.17061@localhost.localdomain \
    --to=rpjday@mindspring.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®