mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: Greg KH <greg@kroah.com>
Cc: Yinghai Lu <Yinghai.Lu@Sun.COM>,
	akpm@linux-foundation.org, ak@suse.de, rientjes@google.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] try parent numa_node at first before using default
Date: Mon, 9 Jul 2007 17:52:34 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0707091751410.2269@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20070710004416.GA6905@kroah.com>

On Mon, 9 Jul 2007, Greg KH wrote:

> > @@ -547,6 +547,8 @@ static void klist_children_put(struct klist_node *n)
> >  
> >  void device_initialize(struct device *dev)
> >  {
> > +	int node;
> > +
> >  	kobj_set_kset_s(dev, devices_subsys);
> >  	kobject_init(&dev->kobj);
> >  	klist_init(&dev->klist_children, klist_children_get,
> > @@ -557,7 +559,9 @@ void device_initialize(struct device *dev)
> >  	spin_lock_init(&dev->devres_lock);
> >  	INIT_LIST_HEAD(&dev->devres_head);
> >  	device_init_wakeup(dev, 0);
> > -	set_dev_node(dev, -1);
> > +
> > +	node = dev->parent ? dev_to_node(dev->parent) : -1;
> > +	set_dev_node(dev, node);
> >  }
> 
> What is this going to give us?
> 
> Doesn't it mean that all devices will end up on the same node?

It means that the node for the device is the same as the parent device.
F.e. if the parent device is a bus that is connected to node 4 then all 
the devices hooked up to the bus are allocated on that node.

  reply	other threads:[~2007-07-10  0:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200707031835.l63IZo9K008197@imap1.linux-foundation.org>
2007-07-04  0:31 ` Yinghai Lu
2007-07-10  0:44   ` Greg KH
2007-07-10  0:52     ` Christoph Lameter [this message]
2007-07-10  4:49       ` Greg KH
2007-07-10  6:22         ` Yinghai Lu
2007-07-10  1:03     ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0707091751410.2269@schroedinger.engr.sgi.com \
    --to=clameter@sgi.com \
    --cc=Yinghai.Lu@Sun.COM \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®