mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: William Tambe <tambewilliam@gmail.com>
Cc: Stas Sergeev <stsp@aknet.ru>,
	"Rohland, Hans-Christoph" <hans-christoph.rohland@sap.com>,
	linux-kernel@vger.kernel.org
Subject: Re: Concerning a post that you made about expandable anonymous shared mappings
Date: Tue, 10 Jul 2007 21:10:11 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0707102056140.4107@blonde.wat.veritas.com> (raw)
In-Reply-To: <4692E5DF.7080304@gmail.com>

On Mon, 9 Jul 2007, William Tambe wrote:
> Hugh Dickins wrote:
> > 
> > I've come right around to your original view, Stas, and William's:
> > if that mmap creates such an object, then the expanding mremap really
> > ought to be useful, and allow the underlying object to be expanded.
> > The shared anonymous object is already anomalous: expanding it on
> > fault makes it more consistent with its own nature, not less.
> > ...
> > Here's a patch against 2.6.22-rc7: would you, Stas, put your
> > Signed-off-by into this, and accept authorship - although I'm
> > sending this back to you, it's very much your idea, and only
> > trivially modified from your three-year-old patch by me.  If
> > you're agreeable, I can then forward it or its shmem_zero_fault
> > equivalent to Andrew when we see which way 2.6.23 is going.
>... 
> Will this patch be added to stable versions of the linux kernel?
> Please let me know.

I confess that the lukewarm response from Stas cooled my enthusiasm,
and left me feeling that perhaps I'm an idiot to be adding such a
feature so many years too late; and my old caution about the way
a child could use up memory not freed on child's exit, unknown to
parent, returned to haunt me.  That could be documented for new
usages, but I just don't know what usages are already out there,
and fear I'd be introducing an exploit.

It most certainly will not be added to a stable version of the
linux kernel, if by that you mean 2.6.22.N or 2.6.21.N etc.
Though it can be viewed as a bugfix, the patch as it stands
seems in danger of introducing its own bug, and it's just too
much of a feature to be suitable for a -stable release.

But more probably you meant, will it be in 2.6.23 or 2.6.24?
Sorry to be such a vacillatiing wimp, but I don't know.
How well are you managing with the shm_open approach?

Hugh

  reply	other threads:[~2007-07-10 20:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-29 19:52 William Tambe
2007-07-02 15:33 ` Hugh Dickins
2007-07-02 17:35   ` William Tambe
2007-07-02 18:21     ` Stas Sergeev
2007-07-02 18:10   ` Stas Sergeev
2007-07-03 15:48     ` Hugh Dickins
2007-07-03 18:29       ` Stas Sergeev
2007-07-10  1:50       ` William Tambe
2007-07-10 20:10         ` Hugh Dickins [this message]
2007-07-10 20:55           ` William Tambe
2007-07-11  4:12             ` Stas Sergeev
2007-07-12  6:35               ` William Tambe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0707102056140.4107@blonde.wat.veritas.com \
    --to=hugh@veritas.com \
    --cc=hans-christoph.rohland@sap.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stsp@aknet.ru \
    --cc=tambewilliam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®