From: Christoph Lameter <clameter@sgi.com>
To: David Miller <davem@davemloft.net>
Cc: ak@suse.de, linux-kernel@vger.kernel.org, travis@sgi.com,
jeremy@goop.org
Subject: Re: x86: Convert cpu_core_map to be a per cpu variable
Date: Fri, 13 Jul 2007 09:34:02 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0707130933140.21777@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20070713.000814.102125147.davem@davemloft.net>
On Fri, 13 Jul 2007, David Miller wrote:
> From: Christoph Lameter <clameter@sgi.com>
> Date: Thu, 12 Jul 2007 23:58:06 -0700 (PDT)
>
> > cpu_core_map is currently an array defined using NR_CPUS. This means that
> > we overallocate since we will rarely really use the maximum
> > number of configured cpus. This may become a problem when we need to
> > increase the NR_CPUs on x86_64 for our new product line.
>
> I'm using NR_CPUS set to 1024 on my sparc64 workstation, it's
> not that bad to be honest :-) What kind of cpu arity are you
> talking about?
Up to 16k.
> > If we put the cpu_core_map into the per cpu area then it will be allocated
> > for each processor as it comes online.
> >
> > However, this means that the core map cannot be accessed until the per cpu
> > area has been allocated. Xen does a weird thing here looping over all
> > processors and zeroing the masks that are not yet allocated and that will
> > be zeroed when they are allocated. I commented the code out. Maybe there
> > is another purpose? Jeremy?
> >
> > Signed-off-by: Christoph Lameter <clameter@sgi.com>
>
> Please take care of sparc64 if you're going to do this change.
> It uses cpu_core_map too.
But the code modified here is x86_64 and i386 specific? Is there an
overlap?
next prev parent reply other threads:[~2007-07-13 16:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 6:58 Christoph Lameter
2007-07-13 7:08 ` David Miller
2007-07-13 16:34 ` Christoph Lameter [this message]
2007-07-13 22:41 ` David Miller
2007-07-13 22:50 ` Christoph Lameter
2007-07-13 22:51 ` David Miller
2007-07-13 13:49 ` Jeremy Fitzhardinge
2007-07-17 19:27 ` Siddha, Suresh B
2007-07-23 19:34 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0707130933140.21777@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=ak@suse.de \
--cc=davem@davemloft.net \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®