From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755386AbXGPJXF (ORCPT ); Mon, 16 Jul 2007 05:23:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754862AbXGPJWz (ORCPT ); Mon, 16 Jul 2007 05:22:55 -0400 Received: from nic.NetDirect.CA ([216.16.235.2]:51439 "EHLO rubicon.netdirect.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754978AbXGPJWy (ORCPT ); Mon, 16 Jul 2007 05:22:54 -0400 X-Originating-Ip: 74.102.207.204 Date: Mon, 16 Jul 2007 05:20:00 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Geert Uytterhoeven cc: Mike Frysinger , paulus@samba.org, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [patch] use __attribute__ in asm-powerpc In-Reply-To: Message-ID: References: <200707142336.10343.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Net-Direct-Inc-MailScanner-Information: Please contact the ISP for more information X-Net-Direct-Inc-MailScanner: Found to be clean X-Net-Direct-Inc-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-36.8, required 5, autolearn=not spam, ALL_TRUSTED -1.80, BAYES_00 -15.00, INIT_RECVD_OUR_AUTH -20.00) X-Net-Direct-Inc-MailScanner-From: rpjday@mindspring.com Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Jul 2007, Geert Uytterhoeven wrote: > On Sat, 14 Jul 2007, Mike Frysinger wrote: > > Pretty much everyone uses "__attribute__" or "attribute", no one > > uses "__attribute". This patch tweaks the three places in asm-powerpc where > > this comes up. While only asm-powerpc/types.h is interesting (for userspace), > > I did asm-powerpc/processor.h as well for consistency. > > > > Signed-off-by: Mike Frysinger > > --- > > diff --git a/include/asm-powerpc/processor.h b/include/asm-powerpc/processor.h > > index d947b16..2ce6ea6 100644 > > --- a/include/asm-powerpc/processor.h > > +++ b/include/asm-powerpc/processor.h > > @@ -153,9 +153,9 @@ struct thread_struct { > > unsigned long dabr; /* Data address breakpoint register */ > > #ifdef CONFIG_ALTIVEC > > /* Complete AltiVec register set */ > > - vector128 vr[32] __attribute((aligned(16))); > > + vector128 vr[32] __attribute__((aligned(16))); > > If the code is not exported to userspace (and thus not subject to > different compilers), I think the preferred form is plain > `attribute'. compiler-gcc.h also defines the common form of the shortcut: #define __aligned(x) __attribute__((aligned(x))) rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page ========================================================================