From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933155AbXGQIxm (ORCPT ); Tue, 17 Jul 2007 04:53:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752013AbXGQIxf (ORCPT ); Tue, 17 Jul 2007 04:53:35 -0400 Received: from europa.telenet-ops.be ([195.130.137.75]:38187 "EHLO europa.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752AbXGQIxe (ORCPT ); Tue, 17 Jul 2007 04:53:34 -0400 Date: Tue, 17 Jul 2007 10:53:32 +0200 (CEST) From: Geert Uytterhoeven To: Linus Torvalds Cc: Andrew Morton , Heiko Carstens , Linux Kernel Mailing List , zippel@linux-m68k.org, jdike@karaya.com, alan@lxorguk.ukuu.org.uk, Martin Schwidefsky Subject: Re: uninline check_signature() In-Reply-To: Message-ID: References: <200707161802.l6GI2tNp007390@hera.kernel.org> <20070716221257.GA12230@osiris.ibm.com> <20070716152923.ce4a5c5a.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Jul 2007, Geert Uytterhoeven wrote: > On Mon, 16 Jul 2007, Linus Torvalds wrote: > > On Mon, 16 Jul 2007, Andrew Morton wrote: > > > No, no revert, please. If the architecture doesn't support readb() then we > > > need some reliable way of working that out within Kconfig. > > > > Isn't that CONFIG_HAS_IOMEM? > > No, having memory mapped I/O doesn't mean you have PCI. > How to access memory mapped I/O depends on the bus behind the device. Like I said before: | Just make check_signature() depend on ISA || PCI (and maybe || X86_32). It's used by only a handful of legacy drivers. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds