Re: [PATCH][RFC] Delete export of tty.h to userspace.

["Robert P. J. Day" <rpjday@mindspring.com>]

On Thu, 19 Jul 2007, Jiri Slaby wrote:

> Christoph Hellwig napsal(a):
> > On Thu, Jul 19, 2007 at 07:17:07AM -0400, Robert P. J. Day wrote:
> >> so you're saying you'll drop that include from util-linux, is
> >> that it? but it's still a good plan to generate a warning
> >> whenever userspace includes that file, so i'll submit a quick
> >> patch to generate that, based on jiri's suggestion.
> >
> > Not exporting it at all gives an error which is a lot better.
> > Just look at all the warnings most userspace spews, they'd never
> > even notice it otherwise.
>
> Not directly responding to this, but keeping CCs. I though of the
> removal one more time and there is one more issue (maybe). Every
> exported kernel header, which includes this file outside #ifdef
> __KERNEL__ #endif will be broken in userspace. Are you sure, there
> are no such includes?

yes, i checked the output from "make headers_install" as my first test
before proposing this.  there's nothing anywhere in that output that
includes tty.h.  that is, as long as i didn't screw up somewhere along
the way.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================