mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andi Kleen <andi@firstfloor.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] mm: reduce pagetable-freeing latencies
Date: Thu, 26 Jul 2007 18:11:32 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0707261758280.370@blonde.wat.veritas.com> (raw)
In-Reply-To: <1185360414.5439.335.camel@localhost.localdomain>

On Wed, 25 Jul 2007, Benjamin Herrenschmidt wrote:
> 
> In fact, i discussed with peter and I think the best is to only have one
> entry in the stack mmu_gather structure.

Four or eight would be much nicer than one, but you're right there's
a stackdepth worry: good spotting of those unmap_mapping_range cases,
I'd certainly been thinking we were fairly near the top of the stack
in unmap_vmas, which is not so (or not obviously so) in those cases.

> If we fail to allocate a page
> to batch entries, we flush that one and steal it :-) Then we have a page
> to gather more.

That will often be the case for anonymous pages, but not for pagecache
pages.  I had wondered whether to make exit_mmap unmap the stack first
(rather than text first as usually happens), but seems rather a hack.

Hugh

  reply	other threads:[~2007-07-26 17:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-24  8:38 Ingo Molnar
2007-07-24  8:54 ` Andrew Morton
2007-07-24  9:40   ` Benjamin Herrenschmidt
2007-07-24 12:13     ` Andi Kleen
2007-07-24 21:29       ` Benjamin Herrenschmidt
2007-07-25  6:44         ` Peter Zijlstra
2007-07-25  9:46           ` Andi Kleen
2007-07-25 10:08             ` Benjamin Herrenschmidt
2007-07-25 10:26               ` Andi Kleen
2007-07-25 10:46                 ` Benjamin Herrenschmidt
2007-07-26 17:11                   ` Hugh Dickins [this message]
2007-07-26 21:35                     ` Benjamin Herrenschmidt
2007-07-28  1:36           ` Benjamin Herrenschmidt
2007-07-28  5:54             ` Hugh Dickins
2007-07-28 22:36               ` Benjamin Herrenschmidt
2007-07-24 11:22   ` Ingo Molnar
2007-07-24  9:40 ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0707261758280.370@blonde.wat.veritas.com \
    --to=hugh@veritas.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®