mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: Henrique de Moraes Holshuh <hmh@hmh.eng.br>
Cc: Len Brown <len.brown@intel.com>,
	Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: THINKPAD_ACPI_INPUT_ENABLED seems regressive
Date: Wed, 1 Aug 2007 14:07:27 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0708011327200.4615@blonde.wat.veritas.com> (raw)

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1287 bytes --]

When updating this IBM ThinkPad T43p from 2.6.22 to 2.6.23-rc1
using make oldconfig, the text and default Y of

config THINKPAD_ACPI_INPUT_ENABLED
	bool "Enable input layer support by default"
	depends on THINKPAD_ACPI
	default y
	---help---
	  Enables hot key handling over the input layer by default.  If unset,
	  the driver does not enable any hot key handling by default, and also
	  starts up with a mostly empty keymap.

	  If you are not sure, say Y here.  Say N to retain the deprecated
	  behavior of ibm-acpi, and thinkpad-acpi for kernels up to 2.6.21.

made it sound like a good thing, so I configured it Y.  But its only
effect seems to be to disable the key I use most, Fn+F4 to suspend to
RAM.  It also disables Fn+F3 to blank the screen, though I don't use
that one; but does not disable the brightness and ThinkLight keys,
presumably because they just get mapped to KEY_RESERVED.

The same remains true with latest kernel git.  Perhaps there's some
other config option without which this option is useless, which I
don't have set?  My .config for latest git attached.

I get along fine now with THINKPAD_ACPI_INPUT_ENABLED disabled; but
suggest that its text is misleading, and default Y questionable.
Or perhaps there's a bug, and I can help try patches.

Thanks,
Hugh

[-- Attachment #2: T43p config --]
[-- Type: APPLICATION/x-config, Size: 31880 bytes --]

             reply	other threads:[~2007-08-01 13:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-01 13:07 Hugh Dickins [this message]
2007-08-01 15:36 ` Henrique de Moraes Holschuh
2007-08-01 16:08   ` Michael S. Tsirkin
2007-08-01 16:24     ` Henrique de Moraes Holschuh
2007-08-01 17:03       ` Hugh Dickins
2007-08-01 18:01         ` [ibm-acpi-devel] " Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0708011327200.4615@blonde.wat.veritas.com \
    --to=hugh@veritas.com \
    --cc=hmh@hmh.eng.br \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®