From: Christoph Lameter <clameter@sgi.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 4/6] SLUB: Avoid touching page struct when freeing to per cpu slab
Date: Fri, 24 Aug 2007 09:46:39 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0708240944020.20501@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0708231229030.14478@schroedinger.engr.sgi.com>
On Thu, 23 Aug 2007, Christoph Lameter wrote:
> So we need to also check for -1 if !NUMA
>
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
Sorry. No we do not need this fix. The patch is fine as is.
In slab_alloc() the slow path is entered if c->lockless is NULL. So it
does not matter for slow path determination that node_match always returns
1 in the !NUMA case.
c->node only needs to be checked for slow path determination in
slab_free(). And there the node_match is not called.
next prev parent reply other threads:[~2007-08-24 16:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-23 6:46 [patch 0/6] Per cpu structures for SLUB Christoph Lameter
2007-08-23 6:46 ` [patch 1/6] SLUB: Avoid page struct cacheline bouncing due to remote frees to cpu slab Christoph Lameter
2007-08-23 6:46 ` [patch 2/6] SLUB: Do not use page->mapping Christoph Lameter
2007-08-23 6:46 ` [patch 3/6] SLUB: Move page->offset to kmem_cache_cpu->offset Christoph Lameter
2007-08-23 6:46 ` [patch 4/6] SLUB: Avoid touching page struct when freeing to per cpu slab Christoph Lameter
2007-08-23 15:05 ` Peter Zijlstra
2007-08-23 19:30 ` Christoph Lameter
2007-08-24 16:46 ` Christoph Lameter [this message]
2007-08-23 6:46 ` [patch 5/6] SLUB: Place kmem_cache_cpu structures in a NUMA aware way Christoph Lameter
2007-08-23 6:46 ` [patch 6/6] SLUB: Optimize cacheline use for zeroing Christoph Lameter
2007-08-23 9:52 ` [patch 0/6] Per cpu structures for SLUB Peter Zijlstra
2007-08-23 19:25 ` Christoph Lameter
2007-08-24 21:38 ` Andrew Morton
2007-08-27 18:50 ` Christoph Lameter
2007-08-27 23:51 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0708240944020.20501@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®