From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -mm] add-a-rounddown_pow_of_two-routine-to-log2h.patch fix
Date: Sat, 1 Sep 2007 02:46:07 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0709010245440.21492@localhost.localdomain> (raw)
In-Reply-To: <200709010755.37838.m.kozlowski@tuxland.pl>
On Sat, 1 Sep 2007, Mariusz Kozlowski wrote:
> Hello,
>
> This patch fixes the unbalanced parenthesis inroduced by
> add-a-rounddown_pow_of_two-routine-to-log2h.patch.
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> include/linux/log2.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.23-rc4-mm1-a/include/linux/log2.h 2007-09-01 07:23:28.000000000 +0200
> +++ linux-2.6.23-rc4-mm1-b/include/linux/log2.h 2007-09-01 07:29:27.000000000 +0200
> @@ -186,7 +186,7 @@ unsigned long __rounddown_pow_of_two(uns
> ( \
> __builtin_constant_p(n) ? ( \
> (n == 1) ? 0 : \
> - (1UL << ilog2(n)) : \
> + (1UL << ilog2(n))) : \
> __rounddown_pow_of_two(n) \
> )
>
> -
oh, crap ... how did that happen? sorry.
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://crashcourse.ca
========================================================================
next prev parent reply other threads:[~2007-09-01 6:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-01 5:55 Mariusz Kozlowski
2007-09-01 6:46 ` Robert P. J. Day [this message]
2007-09-12 3:43 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0709010245440.21492@localhost.localdomain \
--to=rpjday@mindspring.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.kozlowski@tuxland.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®