From: Roman Zippel <zippel@linux-m68k.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
Mike Galbraith <efault@gmx.de>
Subject: Re: [ANNOUNCE/RFC] Really Simple Really Fair Scheduler
Date: Mon, 3 Sep 2007 21:55:20 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0709032140140.1817@scrub.home> (raw)
In-Reply-To: <20070903192050.GA29049@elte.hu>
Hi,
On Mon, 3 Sep 2007, Ingo Molnar wrote:
> My next question then is about this code of yours in the wakeup path:
>
> +static void
> +enqueue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
> +{
> + kclock_t min_time;
> +
> + verify_queue(cfs_rq, cfs_rq->curr != se, se);
> + min_time = get_time_avg(cfs_rq) - se->req_weight_inv;
> + if ((kclock_t)(se->time_norm - min_time) < 0)
> + se->time_norm = min_time;
>
> why do you only use the "min_time" if the pre-sleep time_norm is smaller
> than the min_time? Here 'min_time' is close to the current average.
It's a variation of the sleeper bonus. Let's assume two running tasks
which have been running for 95ms and 105ms and a time slice of 10ms, the
average is thus 100ms. If the new task has been sleeping for a while it
starts at 90ms, if the task had been running lately it doesn't get this
bonus again.
> Shouldnt here the woken up task be set to the average time, like i did
> it in the crude prototype:
>
> + se->exec_runtime = avg_exec_runtime(cfs_rq);
That would be equivalent to simply clearing wait_runtime in CFS.
bye, Roman
next prev parent reply other threads:[~2007-09-03 19:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-02 12:01 Ingo Molnar
2007-09-02 19:12 ` Tong Li
2007-09-02 19:44 ` Ingo Molnar
2007-09-03 18:38 ` Roman Zippel
2007-09-03 18:54 ` Ingo Molnar
2007-09-03 19:13 ` Roman Zippel
2007-09-03 19:20 ` Ingo Molnar
2007-09-03 19:55 ` Roman Zippel [this message]
2007-09-03 20:04 ` Ingo Molnar
2007-09-04 2:50 ` Roman Zippel
2007-09-04 6:29 ` Ingo Molnar
2007-09-04 11:21 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0709032140140.1817@scrub.home \
--to=zippel@linux-m68k.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®