From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761857AbXIZSoZ (ORCPT ); Wed, 26 Sep 2007 14:44:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753099AbXIZSoR (ORCPT ); Wed, 26 Sep 2007 14:44:17 -0400 Received: from netops-testserver-4-out.sgi.com ([192.48.171.29]:49666 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758078AbXIZSoQ (ORCPT ); Wed, 26 Sep 2007 14:44:16 -0400 Date: Wed, 26 Sep 2007 11:44:15 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Hugh Dickins cc: Peter Zijlstra , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] LBS: fix uninitialized swapper_space In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Sep 2007, Hugh Dickins wrote: > Probably better, yes. In -mm Peter is doing an #ifdef CONFIG_SWAP > bdi_init() on swapper_space. Would make sense to do both together, > perhaps move them to a swapper_space_init() in swap_state.c, saving > his #ifdef too. I suggest leave such cleanups until one or the > other is mainlined. Ok. I have updated the largeblock git tree with your patches and a new revision of the mmap patches. Still working on it. Fallback in the block layer is not yet working. I probably need to look at Nick's patches a bit.