From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761010AbXIZSfQ (ORCPT ); Wed, 26 Sep 2007 14:35:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753359AbXIZSfA (ORCPT ); Wed, 26 Sep 2007 14:35:00 -0400 Received: from extu-mxob-1.symantec.com ([216.10.194.28]:34360 "EHLO extu-mxob-1.symantec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754319AbXIZSe7 (ORCPT ); Wed, 26 Sep 2007 14:34:59 -0400 Date: Wed, 26 Sep 2007 19:34:29 +0100 (BST) From: Hugh Dickins X-X-Sender: hugh@blonde.wat.veritas.com To: Christoph Lameter cc: Peter Zijlstra , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] LBS: fix uninitialized swapper_space In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 Sep 2007, Christoph Lameter wrote: > On Fri, 21 Sep 2007, Hugh Dickins wrote: > > > Swapping crashed immediately: must initialize new fields of swapper_space. > > Thanks for finding that. It may be better though to use the new > mapping_setup() function instead? That way there is no #ifdef. Probably better, yes. In -mm Peter is doing an #ifdef CONFIG_SWAP bdi_init() on swapper_space. Would make sense to do both together, perhaps move them to a swapper_space_init() in swap_state.c, saving his #ifdef too. I suggest leave such cleanups until one or the other is mainlined. Hugh