Re: [PATCH] Generic compat_sys_fallocate

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Fri, 28 Sep 2007, Kyle McMartin wrote:
> --- a/fs/compat.c
> +++ b/fs/compat.c
> @@ -2226,3 +2226,13 @@ asmlinkage long compat_sys_timerfd(int ufd, int clockid, int flags,
>  }
>  
>  #endif /* CONFIG_TIMERFD */
> +
> +asmlinkage long compat_sys_fallocate(int fd, int mode,
> +				     u32 offset_lo, u32 offset_hi,
> +				     u32 len_lo, u32 len_hi)
> +{
> +	u64 offset = compat_merge64(offset_lo, offset_hi);
> +	u64 len = compat_merge64(len_lo, len_hi);
> +
> +	return sys_fallocate(fd, mode, offset, len);
> +}

To avoid confusion, you may want to rename the *_{lo,hi} parameters to
e.g. *_{l,r}, as they don't actually mean the low and high part anymore.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds