From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: roel <12o3l@tiscali.nl>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] removes array_size duplicates
Date: Mon, 1 Oct 2007 05:55:25 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0710010553420.30185@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0710010546340.15688@localhost.localdomain>
On Mon, 1 Oct 2007, Robert P. J. Day wrote:
...
> among other things, one of the creepy issues here is the definition in
> include/linux/netfilter/xt_sctp.h of the macro:
>
> ...
> #define SCTP_CHUNKMAP_COPY(destmap, srcmap) \
> do { \
> int i; \
> for (i = 0; i < ELEMCOUNT(chunkmap); i++) \
^^^^^^^^
srcmap??
> destmap[i] = srcmap[i]; \
> } while (0)
> ...
>
whoops, i take it back ... isn't this just a flat-out error, where the
macro should be written with the correction above?
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://crashcourse.ca
========================================================================
prev parent reply other threads:[~2007-10-01 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 22:51 roel
2007-10-01 9:26 ` Andrew Morton
2007-10-01 9:33 ` Geert Uytterhoeven
2007-10-01 9:39 ` Andrew Morton
2007-10-01 9:48 ` Robert P. J. Day
2007-10-01 9:55 ` Robert P. J. Day [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0710010553420.30185@localhost.localdomain \
--to=rpjday@mindspring.com \
--cc=12o3l@tiscali.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®