mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -mm] slub: fix cpu hotplug offline/online path
Date: Tue, 9 Oct 2007 11:46:14 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0710091144020.32162@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20071009161328.GA6470@APFDCB5C>

On Wed, 10 Oct 2007, Akinobu Mita wrote:

> This patch removes init_alloc_cpu_cpu() from cpu hotplug notifier. But
> call it for each possible CPUs not only online CPUs at initialization time.

Could you check if a per cpu structure has already been allocated and then 
simply skip the call to init? Otherwise we end up with lots of per cpu 
structures for cpus that will never show up. 

if (!get_cpu_slab(s, cpu))
	init_alloc_cpu_cpu( ...)


  parent reply	other threads:[~2007-10-09 18:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-09 16:13 Akinobu Mita
2007-10-09 17:41 ` Pekka Enberg
2007-10-09 18:46 ` Christoph Lameter [this message]
2007-10-09 18:48   ` Pekka Enberg
2007-10-09 18:50     ` Christoph Lameter
2007-10-09 19:02       ` Pekka Enberg
2007-10-09 19:15         ` Christoph Lameter
2007-10-10 12:18   ` Akinobu Mita
2007-10-10 17:39     ` Christoph Lameter
2007-10-11 14:36       ` Akinobu Mita
2007-10-11 16:46         ` Christoph Lameter
2007-10-11 17:24           ` Akinobu Mita
2007-10-11 17:36             ` Christoph Lameter
2007-10-11 17:37         ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0710091144020.32162@schroedinger.engr.sgi.com \
    --to=clameter@sgi.com \
    --cc=akinobu.mita@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®