From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756971AbXJJVJg (ORCPT ); Wed, 10 Oct 2007 17:09:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755606AbXJJVJ3 (ORCPT ); Wed, 10 Oct 2007 17:09:29 -0400 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:40338 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755577AbXJJVJ2 (ORCPT ); Wed, 10 Oct 2007 17:09:28 -0400 Date: Wed, 10 Oct 2007 14:09:25 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Jeremy Fitzhardinge cc: Andi Kleen , William Lee Irwin III , Ingo Molnar , Thomas Gleixner , Andrew Morton , Linux Kernel Mailing List Subject: Re: [PATCH] i386: remove dead code in pgtable_cache_init In-Reply-To: <470D3846.1000209@goop.org> Message-ID: References: <470D3846.1000209@goop.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Oct 2007, Jeremy Fitzhardinge wrote: > The conversion from using a slab cache to quicklist left some residual dead code. > > I note that in the conversion it now always allocates a whole page for > the pgd, rather than the 32 bytes needed for a PAE pgd. Was this > intended? I believe that virtualization support needed a full pgd.