mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Rob Landley <rob@landley.net>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>, linux-kernel@vger.kernel.org
Subject: Re: m68k Kconfig undefined symbol in 2.6.23.
Date: Thu, 11 Oct 2007 08:05:42 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0710110756010.2012@localhost.localdomain> (raw)
In-Reply-To: <200710101719.52423.rob@landley.net>

On Wed, 10 Oct 2007, Rob Landley wrote:

> The m68k Kconfig tries to select a symbol (APM_EMULATION) that doesn't exist.
>
> I did this to fix it, without really understanding the larger problem.  (Did
> APM go away?)  Just FYI...
>
> Rob
>
> diff -r 79f0ea1e0e70 drivers/macintosh/Kconfig
> --- a/drivers/macintosh/Kconfig	Tue Oct 09 21:00:40 2007 +0000
> +++ b/drivers/macintosh/Kconfig	Wed Oct 10 17:17:07 2007 -0500
> @@ -116,11 +116,6 @@ config PMAC_SMU
>  	  on the "SMU" system control chip which replaces the old PMU.
>  	  If you don't know, say Y.
>
> -config PMAC_APM_EMU
> -	tristate "APM emulation"
> -	select APM_EMULATION
> -	depends on ADB_PMU && PM && PPC32
> -
>  config PMAC_MEDIABAY
>  	bool "Support PowerBook hotswap media bay"
>  	depends on PPC_PMAC && PPC32

the obvious problem with the above is that APM_EMULATION is defined in
kernel/power/Kconfig arch-independently thusly:

config APM_EMULATION
        tristate "Advanced Power Management Emulation"
        depends on PM && SYS_SUPPORTS_APM_EMULATION
        help
        ... blah blah ...

but the Kconfig variable SYS_SUPPORTS_APM_EMULATION is defined for
only a small subset of architectures:

$ grep "config SYS_SUPPORTS_APM_EMULATION" $(find . -name Kconfig*)
./arch/mips/Kconfig:config SYS_SUPPORTS_APM_EMULATION
./arch/sh/Kconfig:config SYS_SUPPORTS_APM_EMULATION
./arch/arm/Kconfig:config SYS_SUPPORTS_APM_EMULATION
./arch/powerpc/Kconfig:config SYS_SUPPORTS_APM_EMULATION

  so there's a good chance that doing a kernel config with any other
arch than those listed above that supports PM is going to generate the
same warning.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================

      parent reply	other threads:[~2007-10-11 12:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-10 22:19 Rob Landley
2007-10-11  7:16 ` Geert Uytterhoeven
2007-10-11 12:05 ` Robert P. J. Day [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0710110756010.2012@localhost.localdomain \
    --to=rpjday@mindspring.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®