From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753537AbXJSLVI (ORCPT ); Fri, 19 Oct 2007 07:21:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755263AbXJSLUq (ORCPT ); Fri, 19 Oct 2007 07:20:46 -0400 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:35062 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754950AbXJSLUp (ORCPT ); Fri, 19 Oct 2007 07:20:45 -0400 Date: Fri, 19 Oct 2007 04:20:44 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Nick Piggin cc: Linux Kernel Mailing List , akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: SLUB: Avoid atomic operation for slab_unlock In-Reply-To: <200710190949.01019.nickpiggin@yahoo.com.au> Message-ID: References: <200710190949.01019.nickpiggin@yahoo.com.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Christoph Lameter Slub can use the non-atomic version to unlock because other flags will not get modified with the lock held. Signed-off-by: Nick Piggin --- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6/mm/slub.c =================================================================== --- linux-2.6.orig/mm/slub.c +++ linux-2.6/mm/slub.c @@ -1185,7 +1185,7 @@ static __always_inline void slab_lock(st static __always_inline void slab_unlock(struct page *page) { - bit_spin_unlock(PG_locked, &page->flags); + __bit_spin_unlock(PG_locked, &page->flags); } static __always_inline int slab_trylock(struct page *page)