From: Christoph Lameter <clameter@sgi.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] slub: fix Objects count
Date: Sat, 3 Nov 2007 12:33:01 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0711031226131.5695@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0711031904470.14407@blonde.wat.veritas.com>
On Sat, 3 Nov 2007, Hugh Dickins wrote:
> I was afraid you might say something like that.
> Perhaps it'll be a patch I need to use in my own builds.
> Though I'd have thought others would want that accuracy too.
> Didn't SLAB give it? (The "r*gr*ss**n" word!)
Slab also only counts objects that are not in the queues. See free_block()
f.e.
We could improve the situation by flushing all cpu slabs before counts are
determined.
Which can be done manually. Run
slabinfo -s
and then look at the numbers.
> > Adds to much overhead to the fast paths
>
> You've come to that conclusion very quickly!
I have just spend a few weeks optimizing the fast and slow paths and there
is some additional overhead that I am still trying to eliminate.
> Any numbers to back it up?
The performance in the fast paths depends on updating only a single word
for an allocation. Adding another counter makes that impossible.
See the recent post on SLUB regression on SMP.
next prev parent reply other threads:[~2007-11-03 19:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-03 17:10 [PATCH 1/2] slub: fix leakage Hugh Dickins
2007-11-03 17:11 ` [PATCH 2/2] slub: fix Objects count Hugh Dickins
2007-11-03 18:26 ` Christoph Lameter
2007-11-03 19:09 ` Hugh Dickins
2007-11-03 19:33 ` Christoph Lameter [this message]
2007-11-03 20:03 ` Hugh Dickins
2007-11-03 17:27 ` [PATCH 1/2] slub: fix leakage Olivér Pintér
2007-11-03 17:50 ` Hugh Dickins
2007-11-03 18:52 ` Hugh Dickins
2007-11-03 19:39 ` Hugh Dickins
2007-11-03 19:47 ` Christoph Lameter
2007-11-03 19:52 ` Hugh Dickins
2007-11-03 19:54 ` Christoph Lameter
2007-11-03 20:10 ` Hugh Dickins
2007-11-03 20:26 ` Christoph Lameter
2007-11-04 11:18 ` Hugh Dickins
2007-11-05 18:45 ` Christoph Lameter
2007-11-05 19:09 ` Hugh Dickins
2007-11-05 19:15 ` Christoph Lameter
2007-11-05 19:23 ` Christoph Lameter
2007-11-05 19:26 ` Linus Torvalds
2007-11-05 19:31 ` Christoph Lameter
2007-11-05 19:36 ` Linus Torvalds
2007-11-06 6:15 ` Jeff Chua
2007-11-06 7:58 ` Hugh Dickins
2007-11-03 17:38 ` Willy Tarreau
2007-11-03 17:55 ` Hugh Dickins
2007-11-03 17:59 ` Willy Tarreau
2007-11-03 18:31 ` Christoph Lameter
2007-11-03 18:48 ` Christoph Lameter
2007-11-03 18:51 ` Christoph Lameter
2007-11-03 19:04 ` Hugh Dickins
2007-11-03 19:26 ` Christoph Lameter
2007-11-03 19:35 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0711031226131.5695@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®