From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: duplicated include files
Date: Mon, 5 Nov 2007 09:27:16 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0711050924420.6173@anakin> (raw)
In-Reply-To: <Pine.LNX.4.64.0711041229580.27153@localhost.localdomain>
On Sun, 4 Nov 2007, Robert P. J. Day wrote:
> given the recent patches to remove duplicated #include preprocessor
> directives in source files, let it be known that there are a number of
> them:
>
> http://www.crashcourse.ca/wiki/index.php/Duplicate_include_files
>
> help yourself.
Thanks!
drivers/scsi/gvp11.c is a false positive, as it includes "gvp11.h" once
without HOSTS_C defined and once with.
drivers/scsi/mvme147.c looks similar, but "mvme147.h" does not check for
HOSTS_C (anymore?).
But both need a cleanup anyway...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2007-11-05 8:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-04 17:31 Robert P. J. Day
2007-11-04 18:07 ` Randy Dunlap
2007-11-04 18:37 ` Robert P. J. Day
2007-11-04 18:46 ` Randy Dunlap
2007-11-04 19:03 ` Adrian Bunk
2007-11-04 19:10 ` Robert P. J. Day
2007-11-05 3:02 ` Paul Mundt
2007-11-05 8:27 ` Geert Uytterhoeven [this message]
2007-11-04 19:41 Marco Costalba
2007-11-04 19:43 ` Marco Costalba
2007-11-04 19:49 ` Robert P. J. Day
2007-11-04 23:20 ` Jeremy Fitzhardinge
2007-11-05 3:49 ` Robert P. J. Day
2007-11-04 23:43 ` Bernd Petrovitsch
2007-11-04 19:51 ` Randy Dunlap
2007-11-05 10:51 ` Geert Uytterhoeven
2007-11-05 11:38 ` Marco Costalba
2007-11-14 20:40 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0711050924420.6173@anakin \
--to=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®