mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Davide Libenzi <davidel@xmailserver.org>
To: Michael Kerrisk <mtk.manpages@googlemail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Michael Kerrisk <mtk-manpages@gmx.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [patch 2/4] Timerfd v2 - new timerfd API
Date: Sat, 24 Nov 2007 12:52:27 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0711241250510.10489@alien.or.mcafeemobile.com> (raw)
In-Reply-To: <4747B3F0.2020705@gmail.com>

On Sat, 24 Nov 2007, Michael Kerrisk wrote:

> > +asmlinkage long sys_timerfd_create(int clockid, int flags)
> >  {
> > -	int error;
> > +	int error, ufd;
> >  	struct timerfd_ctx *ctx;
> >  	struct file *file;
> >  	struct inode *inode;
> > -	struct itimerspec ktmr;
> > -
> > -	if (copy_from_user(&ktmr, utmr, sizeof(ktmr)))
> > -		return -EFAULT;
> >  
> >  	if (clockid != CLOCK_MONOTONIC &&
> >  	    clockid != CLOCK_REALTIME)
> >  		return -EINVAL;
> 
> Could I suggest here, the following placeholder addition:
> 
> 	if (flags != 0)
> 		return -EINVAL;

Make sense, will repost.


- Davide



      reply	other threads:[~2007-11-24 20:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-23 21:51 Davide Libenzi
2007-11-24  5:17 ` Michael Kerrisk
2007-11-24 20:52   ` Davide Libenzi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0711241250510.10489@alien.or.mcafeemobile.com \
    --to=davidel@xmailserver.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk-manpages@gmx.net \
    --cc=mtk.manpages@googlemail.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®