From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1756157AbXK0Ur5@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756157AbXK0Ur5 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 27 Nov 2007 15:47:57 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756833AbXK0Uru
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 27 Nov 2007 15:47:50 -0500
Received: from x35.xmailserver.org ([64.71.152.41]:33750 "EHLO
	x35.xmailserver.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756617AbXK0Urt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 27 Nov 2007 15:47:49 -0500
X-AuthUser: davidel@xmailserver.org
Date: Tue, 27 Nov 2007 12:47:46 -0800 (PST)
From: Davide Libenzi <davidel@xmailserver.org>
X-X-Sender: davide@alien.or.mcafeemobile.com
To: Andrew Morton <akpm@linux-foundation.org>
cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Michael Kerrisk <mtk-manpages@gmx.net>,
       Thomas Gleixner <tglx@linutronix.de>,
       Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [patch 2/4] Timerfd v3 - new timerfd API
In-Reply-To: <20071127010254.133e222f.akpm@linux-foundation.org>
Message-ID: <Pine.LNX.4.64.0711271246400.28962@alien.or.mcafeemobile.com>
References: <send-serie.davidel@xmailserver.org.18989.1196028860.2>
 <20071127010254.133e222f.akpm@linux-foundation.org>
X-GPG-FINGRPRINT: CFAE 5BEE FD36 F65E E640  56FE 0974 BF23 270F 474E
X-GPG-PUBLIC_KEY: http://www.xmailserver.org/davidel.asc
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 27 Nov 2007, Andrew Morton wrote:

> On Sun, 25 Nov 2007 14:14:19 -0800 Davide Libenzi <davidel@xmailserver.org> wrote:
> 
> > +static struct file *timerfd_fget(int fd)
> > +{
> > +	struct file *file;
> > +
> > +	file = fget(fd);
> > +	if (!file)
> > +		return ERR_PTR(-EBADF);
> > +	if (file->f_op != &timerfd_fops) {
> > +		fput(file);
> > +		return ERR_PTR(-EINVAL);
> > +	}
> > +
> > +	return file;
> > +}
> 
> I suppose we could use fget_light() in here sometime.  It is significantly
> quicker in microbenchmarks.  Or it was - nobody has checked that in a few
> years afaik.

Should I now? Half of the internet traffic of the last three month was 
generated by me posting those timerfd patches :)



- Davide