From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756761AbXLBUFi (ORCPT ); Sun, 2 Dec 2007 15:05:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754843AbXLBUF3 (ORCPT ); Sun, 2 Dec 2007 15:05:29 -0500 Received: from mgw2.diku.dk ([130.225.96.92]:45456 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754456AbXLBUF2 (ORCPT ); Sun, 2 Dec 2007 15:05:28 -0500 Date: Sun, 2 Dec 2007 21:05:24 +0100 (CET) From: Julia Lawall To: wli@holomorphy.com, davem@davemloft.net, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 2/3] arch/sparc: Add missing of_node_put Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julia Lawall There should be an of_node_put when breaking out of a loop that iterates using for_each_node_by_type. This was detected and fixed using the following semantic patch. (http://www.emn.fr/x-info/coccinelle/) // @@ identifier d; type T; expression e; iterator for_each_node_by_type; @@ T *d; ... for_each_node_by_type(d,...) {... when != of_node_put(d) when != e = d ( return d; | + of_node_put(d); ? return ...; ) ...} // Signed-off-by: Julia Lawall --- diff -u -p a/arch/sparc/kernel/devices.c b/arch/sparc/kernel/devices.c --- a/arch/sparc/kernel/devices.c 2006-11-30 19:04:17.000000000 +0100 +++ b/arch/sparc/kernel/devices.c 2007-12-02 17:57:39.000000000 +0100 @@ -62,8 +62,10 @@ static int __cpu_find_by(int (*compare)( int err = check_cpu_node(dp->node, &cur_inst, compare, compare_arg, prom_node, mid); - if (!err) + if (!err) { + of_node_put(dp); return 0; + } } return -ENODEV;