From: Julia Lawall <julia@diku.dk>
To: Wang Chen <wangchen@cn.fujitsu.com>
Cc: fpavlic@de.ibm.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/3] Fix use of skb after netif_rx
Date: Mon, 10 Dec 2007 08:18:04 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0712100813440.13319@ask.diku.dk> (raw)
In-Reply-To: <475CA464.1060408@cn.fujitsu.com>
> > // </smpl>
> >
> > diff a/drivers/s390/net/ctcmain.c b/drivers/s390/net/ctcmain.c
> > diff a/drivers/s390/net/netiucv.c b/drivers/s390/net/netiucv.c
>
> Julia, seems that your semantic patch misses following place.
>
> drivers/s390/net/qeth_main.c:2733
> ...
> #endif
> rxrc = netif_rx(skb);
> card->dev->last_rx = jiffies;
> card->stats.rx_packets++;
> card->stats.rx_bytes += skb->len;
> ...
Actually, I found this one as well, but I wasn't sure what to do with it.
This one is a bit more complicated because the line with the call to
netif_rx is in an else branch if the #ifdef above is taken. So I wasn't
sure what would be the best way to solve the problem in this case.
Perhaps the solution would be just to save the value of the len field
in a local variable in this case, as you proposed in your original patch.
julia
next prev parent reply other threads:[~2007-12-10 7:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-09 20:05 Julia Lawall
2007-12-10 2:28 ` Wang Chen
2007-12-10 7:18 ` Julia Lawall [this message]
2007-12-10 7:35 ` Wang Chen
2007-12-11 1:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0712100813440.13319@ask.diku.dk \
--to=julia@diku.dk \
--cc=fpavlic@de.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®