From: Hugh Dickins <hugh@veritas.com>
To: Erez Zadok <ezk@cs.sunysb.edu>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: [PATCH 0/4] unionfs: work better with tmpfs
Date: Tue, 18 Dec 2007 22:10:34 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0712182207400.28390@blonde.wat.veritas.com> (raw)
Here's a few patches to unionfs, which together with the tmpfs
patches I just posted, get that combination working better.
fs/stack.c | 6 +++
fs/unionfs/inode.c | 83 +++++++++++++++++++++----------------------
fs/unionfs/mmap.c | 3 -
3 files changed, 47 insertions(+), 45 deletions(-)
But on the way I've noticed a number of issues with unionfs not dealt
with in these patches.
1. Please try unionfs with lockdep configured on (perhaps while running LTP
to get coverage of a variety of cases): I soon gave up, not knowing which
way round the locks should really be taken e.g. unionfs_read_lock versus
unionfs_lock_dentry.
2. I'm worried about the locking generally (no doubt it's difficult!).
My 2/4 patch half-fixes one issue, but raises others: if some function
in a filesystem is usually called with i_mutex held, are you safe to be
calling it (not knowing that lower filesystem) without its i_mutex held?
3. LTP's rename14 tends to fill the filesystem with inodes, which prevent
further tests from running (but not on all machines: a timing issue perhaps).
I have to run LTP with rename14 moved aside.
4. Though you made improvements, some blocks still remain mysteriously
allocated even after the unionfs should be empty e.g. after an LTP run.
Hugh
next reply other threads:[~2007-12-18 22:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-18 22:10 Hugh Dickins [this message]
2007-12-18 22:12 ` [PATCH 1/4] unionfs: remove cap_writeback_dirty test Hugh Dickins
2007-12-18 22:13 ` [PATCH 2/4] unionfs: 32-bit needs lock for i_size Hugh Dickins
2007-12-18 22:14 ` [PATCH 3/4] unionfs: restructure unionfs_setattr Hugh Dickins
2007-12-18 23:09 ` Erez Zadok
2007-12-19 0:53 ` Hugh Dickins
2007-12-19 1:14 ` Erez Zadok
2007-12-18 22:14 ` [PATCH 4/4] unionfs: fix truncation order Hugh Dickins
2007-12-28 21:09 ` [PATCH 0/4] unionfs: work better with tmpfs Erez Zadok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0712182207400.28390@blonde.wat.veritas.com \
--to=hugh@veritas.com \
--cc=akpm@linux-foundation.org \
--cc=ezk@cs.sunysb.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®