From: Julia Lawall <julia@diku.dk>
To: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
Cc: rolandd@cisco.com, mshefty@ichips.intel.com,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 15/38] drivers/infiniband: Use time_before, time_before_eq, etc.
Date: Mon, 24 Dec 2007 16:30:51 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0712241630030.23999@ask.diku.dk> (raw)
In-Reply-To: <20071225.002900.00703855.yoshfuji@linux-ipv6.org>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1014 bytes --]
On Tue, 25 Dec 2007, YOSHIFUJI Hideaki / µÈÆ£±ÑÌÀ wrote:
> In article <Pine.LNX.4.64.0712241528140.23999@ask.diku.dk> (at Mon, 24 Dec 2007 15:28:42 +0100 (CET)), Julia Lawall <julia@diku.dk> says:
>
> > diff -r -u -p a/drivers/infiniband/hw/ipath/ipath_mad.c b/drivers/infiniband/hw/ipath/ipath_mad.c
> > --- a/drivers/infiniband/hw/ipath/ipath_mad.c 2007-10-22 11:25:09.000000000 +0200
> > +++ b/drivers/infiniband/hw/ipath/ipath_mad.c 2007-12-23 20:35:37.000000000 +0100
> > @@ -1334,7 +1334,8 @@ static int process_subn(struct ib_device
> > }
> >
> > /* Is the mkey in the process of expiring? */
> > - if (dev->mkey_lease_timeout && jiffies >= dev->mkey_lease_timeout) {
> > + if (dev->mkey_lease_timeout &&
> > + time_before_eq(jiffies, dev->mkey_lease_timeout)) {
> > /* Clear timeout and mkey protection field. */
> > dev->mkey_lease_timeout = 0;
> > dev->mkeyprot = 0;
>
> time_after_eq()
I see that there are quite a lot of problems like this. I will have to
start over...
julia
prev parent reply other threads:[~2007-12-24 15:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-24 14:28 Julia Lawall
2007-12-24 15:29 ` YOSHIFUJI Hideaki / 吉藤英明
2007-12-24 15:30 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0712241630030.23999@ask.diku.dk \
--to=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mshefty@ichips.intel.com \
--cc=rolandd@cisco.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®