From: Christoph Lameter <clameter@sgi.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Ingo Molnar <mingo@elte.hu>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
andi@firstfloor.org, a.p.zijlstra@chello.nl
Subject: Re: [PATCH] slub: /proc/slabinfo ABI compatibility
Date: Wed, 26 Dec 2007 13:28:45 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0712261323050.16904@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <84144f020712241259o27f4015ai1128fbb675d079ef@mail.gmail.com>
On Mon, 24 Dec 2007, Pekka Enberg wrote:
> On Dec 24, 2007 9:12 PM, Christoph Lameter <clameter@sgi.com> wrote:
> > Hmmm... What is the combination of config variables that causes this? I
> > moved the count_partial function in mm in order to make the merge of slab
> > defrag easier.
>
> I think it's CONFIG_PROC_FS without CONFIG_SYSFS.
The only user of count_partial is in slab_objects() which is in a
section that is
#if defined(CONFIG_SYSFS) && defined(CONFIG_SLUB_DEBUG)
There should be no use if CONFIG_SYSFS is not set. I think we get a
warning about a function that is never called when compiling the current
mm code without SLUB_DEBUG or CONFIG_SYSFS (because the slab defrag use
has not been merged yet).
In mm count_partial() is always defined. In Linus tree count_partial()
comes just before slab_objects().
prev parent reply other threads:[~2007-12-26 21:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-22 12:47 Pekka J Enberg
2007-12-22 13:14 ` Ingo Molnar
2007-12-22 13:31 ` Pekka Enberg
2007-12-22 13:40 ` Ingo Molnar
2007-12-22 13:49 ` Pekka Enberg
2007-12-22 13:16 ` Ingo Molnar
2007-12-22 13:37 ` Ingo Molnar
2007-12-22 13:42 ` Pekka Enberg
2007-12-24 19:12 ` Christoph Lameter
2007-12-24 20:59 ` Pekka Enberg
2007-12-26 21:28 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0712261323050.16904@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®