From: Julia Lawall <julia@diku.dk>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: autofs@linux.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/4] fs/autofs: Use time_before, time_before_eq, etc.
Date: Wed, 26 Dec 2007 20:19:13 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0712262016230.22244@ask.diku.dk> (raw)
In-Reply-To: <477293F3.60304@zytor.com>
On Wed, 26 Dec 2007, H. Peter Anvin wrote:
> Julia Lawall wrote:
> > From: Julia Lawall <julia@diku.dk>
> >
> > The functions time_before, time_before_eq, time_after, and time_after_eq
> > are more robust for comparing jiffies against other values.
> >
>
> More robust, how? You already almost introduced a bug here...
I'm just summarizing the comment that goes with the definition of the
time_after etc functions:
include/linux/jiffies.h:88
/*
* These inlines deal with timer wrapping correctly. You are
* strongly encouraged to use them
* 1. Because people otherwise forget
* 2. Because if the timer wrap changes in future you won't have to
* alter your driver code.
*
julia
next prev parent reply other threads:[~2007-12-26 19:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-26 15:21 Julia Lawall
2007-12-26 17:48 ` H. Peter Anvin
2007-12-26 19:19 ` Julia Lawall [this message]
2007-12-26 19:58 ` Ray Lee
2007-12-26 20:45 ` H. Peter Anvin
2007-12-27 7:08 ` Julia Lawall
2007-12-28 1:39 ` YOSHIFUJI Hideaki / 吉藤英明
2007-12-28 4:34 ` [autofs] " Ian Kent
2007-12-28 9:27 ` Julia Lawall
2007-12-28 14:21 ` [autofs] " Fabio Olive Leite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0712262016230.22244@ask.diku.dk \
--to=julia@diku.dk \
--cc=autofs@linux.kernel.org \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®