From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757913AbXL3PwP (ORCPT ); Sun, 30 Dec 2007 10:52:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756212AbXL3Pv6 (ORCPT ); Sun, 30 Dec 2007 10:51:58 -0500 Received: from mgw1.diku.dk ([130.225.96.91]:53553 "EHLO mgw1.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756185AbXL3Pv5 (ORCPT ); Sun, 30 Dec 2007 10:51:57 -0500 Date: Sun, 30 Dec 2007 16:51:38 +0100 (CET) From: Julia Lawall To: Ingo Molnar Cc: Andi Kleen , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc. In-Reply-To: <20071230154127.GA10444@elte.hu> Message-ID: References: <20071224153152.GA21971@one.firstfloor.org> <20071230133335.GA21106@elte.hu> <20071230154127.GA10444@elte.hu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 30 Dec 2007, Ingo Molnar wrote: > > * Julia Lawall wrote: > > > > your x86 patches (#7, #8 and #9) do not include any *_eq() > > > comparisons and they all seem to be correct. So picked those three > > > up into x86.git - let me know if there's any breakage in them that i > > > missed. > > > > Only #7 is ok. The other two have #include in the wrong > > place. I will send new versions of #8 and #9 shortly. > > hm, #include file order in a .c file should normally not matter - why > are they in the wrong place? Because they are under #ifdefs, but the code that uses the time functions is not under the same #ifdef. julia