From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] driver: tcm825x - fix logical typo error
Date: Fri, 25 Jan 2008 22:05:57 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0801252159140.9538@axis700.grange> (raw)
In-Reply-To: <20080125202720.GD7233@cvg>
On Fri, 25 Jan 2008, Cyrill Gorcunov wrote:
> This patch does fix potential NULL pointer dereference
> due to logical typo error.
>
> The issue is pointed out by
> Guennadi Liakhovetski <g.liakhovetski@pengutronix.de>
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>
> Index: linux-2.6.git/drivers/media/video/tcm825x.c
> ===================================================================
> --- linux-2.6.git.orig/drivers/media/video/tcm825x.c 2008-01-23 19:01:47.000000000 +0300
> +++ linux-2.6.git/drivers/media/video/tcm825x.c 2008-01-25 23:13:15.000000000 +0300
> @@ -851,7 +851,7 @@ static int tcm825x_probe(struct i2c_clie
> sensor->platform_data = client->dev.platform_data;
>
> if (sensor->platform_data == NULL
> - && !sensor->platform_data->is_okay())
> + || !sensor->platform_data->is_okay())
> return -ENODEV;
>
> sensor->v4l2_int_device = &tcm825x_int_device;
Now that it missed 2.6.24, you probably want to send it to -stable too.
Even though the patch is trivial, it might be a good idea to cc: v4l2
maintainer and / or driver author.
Thanks
Guennadi
---
Guennadi Liakhovetski
prev parent reply other threads:[~2008-01-25 21:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-25 20:27 Cyrill Gorcunov
2008-01-25 21:05 ` Guennadi Liakhovetski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0801252159140.9538@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®