From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755268AbYBJUOs (ORCPT ); Sun, 10 Feb 2008 15:14:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753203AbYBJUOk (ORCPT ); Sun, 10 Feb 2008 15:14:40 -0500 Received: from mgw2.diku.dk ([130.225.96.92]:54236 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753075AbYBJUOj (ORCPT ); Sun, 10 Feb 2008 15:14:39 -0500 Date: Sun, 10 Feb 2008 21:14:27 +0100 (CET) From: Julia Lawall To: e1000-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 6/8] drivers/net/igb: Use FIELD_SIZEOF Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julia Lawall Robert P.J. Day proposed to use the macro FIELD_SIZEOF in replace of code that matches its definition. The modification was made using the following semantic patch (http://www.emn.fr/x-info/coccinelle/) // @haskernel@ @@ #include @depends on haskernel@ type t; identifier f; @@ - (sizeof(((t*)0)->f)) + FIELD_SIZEOF(t, f) @depends on haskernel@ type t; identifier f; @@ - sizeof(((t*)0)->f) + FIELD_SIZEOF(t, f) // Signed-off-by: Julia Lawall --- diff -u -p a/drivers/net/igb/igb_ethtool.c b/drivers/net/igb/igb_ethtool.c --- a/drivers/net/igb/igb_ethtool.c 2008-02-02 15:28:20.000000000 +0100 +++ b/drivers/net/igb/igb_ethtool.c 2008-02-10 18:06:35.000000000 +0100 @@ -43,7 +43,7 @@ struct igb_stats { int stat_offset; }; -#define IGB_STAT(m) sizeof(((struct igb_adapter *)0)->m), \ +#define IGB_STAT(m) FIELD_SIZEOF(struct igb_adapter, m), \ offsetof(struct igb_adapter, m) static const struct igb_stats igb_gstrings_stats[] = { { "rx_packets", IGB_STAT(stats.gprc) },