From: Roman Zippel <zippel@linux-m68k.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>, linux-kernel@vger.kernel.org
Subject: Re: hfsplus_unlink...hfsplus_block_free: lockdep warning
Date: Thu, 28 Feb 2008 17:44:30 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0802281731520.2723@scrub.home> (raw)
In-Reply-To: <1204211750.12120.2.camel@twins>
Hi,
On Thu, 28 Feb 2008, Peter Zijlstra wrote:
> > Is this merely a case for annotation?
>
> Being utterly clueless on HFS, and not having had a look yet, I'd say
> its genuine. Esp. since the i_mutex lock class is per filesystem type.
>
> So HFS has internal lock ordering problems, its not interaction with
> another filesystem - like we used to have with ext vs the pseudo
> filesystems.
Please look at the code before you get to such conclusions...
The allocation bitmap is very much organized like a normal file, so HFS+
treats it like a file (e.g. its data is in the page cache), this file is
just not visible outside HFS+, so I used the inode lock to synchronize the
access to it. The lock ordering should be fine, lockdep just doesn't know
about it.
bye, Roman
prev parent reply other threads:[~2008-02-28 16:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-28 15:07 Stefan Richter
2008-02-28 15:15 ` Peter Zijlstra
2008-02-28 16:44 ` Roman Zippel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0802281731520.2723@scrub.home \
--to=zippel@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®