mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Voegtle <tv@lio96.de>
To: linux-kernel@vger.kernel.org
Cc: tilman.baumann@collax.com, Andreas Hofmeister <andi@collax.com>
Subject: permissions on /proc/tty/driver/
Date: Fri, 29 Feb 2008 19:16:51 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.0802291912310.24941@er-systems.de> (raw)

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1054 bytes --]


Hi,

we noticed that only root can enter /proc/tty/driver/, which appears to be 
wrong, because the files therein are actually world readable...



Signed-off-by: Tilman Baumann <tilman.baumann@collax.comy>
Signed-off-by: Thomas Voegtle <tv@lio96.de>
---
 fs/proc/proc_tty.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/proc/proc_tty.c b/fs/proc/proc_tty.c
index 49816e0..eb73d96 100644
--- a/fs/proc/proc_tty.c
+++ b/fs/proc/proc_tty.c
@@ -224,7 +224,9 @@ void __init proc_tty_init(void)
 	 * password lengths and inter-keystroke timings during password
 	 * entry.
 	 */
-	proc_tty_driver = proc_mkdir_mode("tty/driver", S_IRUSR | S_IXUSR, NULL);
+	proc_tty_driver = proc_mkdir_mode("tty/driver",
+			S_IRUSR|S_IXUSR|S_IRGRP|S_IXGRP|S_IROTH|S_IXOTH,
+			NULL);
 
 	create_proc_read_entry("tty/ldiscs", 0, NULL, tty_ldiscs_read_proc, NULL);
 	entry = create_proc_entry("tty/drivers", 0, NULL);
-- 
1.5.3

      Thomas

-- 
 Thomas Vögtle    email: thomas@voegtle-clan.de
 ----- http://www.voegtle-clan.de/thomas ------

             reply	other threads:[~2008-02-29 18:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-29 18:16 Thomas Voegtle [this message]
2008-03-03 16:42 ` Thomas Voegtle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0802291912310.24941@er-systems.de \
    --to=tv@lio96.de \
    --cc=andi@collax.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tilman.baumann@collax.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®