From: Julia Lawall <julia@diku.dk>
To: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
jgarzik@pobox.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH 1/7] drivers/net/wireless/b43/lo.c: remove unused variable
Date: Sat, 15 Mar 2008 17:02:36 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0803151702120.24178@ask.diku.dk> (raw)
From: Julia Lawall <julia@diku.dk>
The variable trsw_rx is initialized but never used otherwise.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
identifier i;
constant C;
@@
(
extern T i;
|
- T i;
<+... when != i
- i = C;
...+>
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/wireless/b43/lo.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff -u -p a/drivers/net/wireless/b43/lo.c b/drivers/net/wireless/b43/lo.c
--- a/drivers/net/wireless/b43/lo.c 2008-03-12 14:13:14.000000000 +0100
+++ b/drivers/net/wireless/b43/lo.c 2008-03-15 15:56:58.000000000 +0100
@@ -493,15 +493,12 @@ static void lo_measure_gain_values(struc
max_rx_gain = 0;
if (has_loopback_gain(phy)) {
- int trsw_rx = 0;
int trsw_rx_gain;
if (use_trsw_rx) {
trsw_rx_gain = phy->trsw_rx_gain / 2;
- if (max_rx_gain >= trsw_rx_gain) {
+ if (max_rx_gain >= trsw_rx_gain)
trsw_rx_gain = max_rx_gain - trsw_rx_gain;
- trsw_rx = 0x20;
- }
} else
trsw_rx_gain = max_rx_gain;
if (trsw_rx_gain < 9) {
next reply other threads:[~2008-03-15 16:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-15 16:02 Julia Lawall [this message]
2008-03-15 16:40 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0803151702120.24178@ask.diku.dk \
--to=julia@diku.dk \
--cc=jgarzik@pobox.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®