From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755322AbYCYIvm (ORCPT ); Tue, 25 Mar 2008 04:51:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751381AbYCYIvb (ORCPT ); Tue, 25 Mar 2008 04:51:31 -0400 Received: from mgw2.diku.dk ([130.225.96.92]:44416 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753593AbYCYIv1 (ORCPT ); Tue, 25 Mar 2008 04:51:27 -0400 Date: Tue, 25 Mar 2008 09:51:20 +0100 (CET) From: Julia Lawall To: "Zhang, Rui" Cc: "Brown, Len" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 4/5] drivers/acpi: elide a non-zero test on a result that is never 0 In-Reply-To: <1206433818.3047.50.camel@acpi-hp-zz.sh.intel.com> Message-ID: References: <1206431411.3047.45.camel@acpi-hp-zz.sh.intel.com> <1206433818.3047.50.camel@acpi-hp-zz.sh.intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > And the return value of thermal_zone_device_register is also > > misused. > I guess you didn't fix this one, right? > Len, please apply this patch.:) Indeed, I did not fix this one. So your patch should be used in this case. julia > > > Check the return value of thermal zone device registration correctly. > > Signed-off-by: Zhang Rui > --- > drivers/acpi/thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6/drivers/acpi/thermal.c > =================================================================== > --- linux-2.6.orig/drivers/acpi/thermal.c > +++ linux-2.6/drivers/acpi/thermal.c > @@ -1125,7 +1125,7 @@ static int acpi_thermal_register_thermal > tz->trips.active[i].flags.valid; i++, trips++); > tz->thermal_zone = thermal_zone_device_register("ACPI thermal zone", > trips, tz, &acpi_thermal_zone_ops); > - if (!tz->thermal_zone) > + if (IS_ERR(tz->thermal_zone)) > return -ENODEV; > > result = sysfs_create_link(&tz->device->dev.kobj, > > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >