mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: 2.6.25-rc8-mm1 (mips build failure)
Date: Wed, 2 Apr 2008 10:33:32 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0804021031480.26938@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20080401230322.331c50f4.akpm@linux-foundation.org>

On Tue, 1 Apr 2008, Andrew Morton wrote:

> On Wed, 02 Apr 2008 09:40:22 +0400 Dmitri Vorobiev <dmitri.vorobiev@gmail.com> wrote:
> 
> > Hi Andrew,
> > 
> > MIPS build fails with the following:
> > 
> > $ make ARCH=mips CROSS_COMPILE=mips-unknown-linux-gnu-
> > ...
> > [skipped]
> > ...
> >   CC      arch/mips/mips-boards/generic/init.o
> > In file included from include/asm/cacheflush.h:13,
> >                  from arch/mips/mips-boards/generic/init.c:30:
> > include/linux/mm.h:411:63: "NR_PAGEFLAGS" is not defined
> > include/linux/mm.h:459:62: "NR_PAGEFLAGS" is not defined
> > make[1]: *** [arch/mips/mips-boards/generic/init.o] Error 1
> > make: *** [arch/mips/mips-boards/generic] Error 2
> 
> ahh, yup, known problem, sorry.  We are slowly working on a fix.

This the fix that I posted a couple of days ago after Andrew noted the 
problem:




From: Christoph Lameter <clameter@sgi.com>
Subject: Allow override of definition for asm constant

MIPS has a different way of defining asm constants which causes troubles
for bounds.h generation (see also the Kbuild script).

Add a new per arch CONFIG variable

	CONFIG_ASM_SYMBOL_PREFIX

which can be set to define an alternate header for asm constant definitions.
Use this for MIPS to make bounds determination work right.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

---
 arch/mips/Kconfig |    7 +++++++
 kernel/bounds.c   |   11 ++++++++++-
 2 files changed, 17 insertions(+), 1 deletion(-)

Index: linux-2.6.25-rc5-mm1/arch/mips/Kconfig
===================================================================
--- linux-2.6.25-rc5-mm1.orig/arch/mips/Kconfig	2008-03-31 13:14:26.888383587 -0700
+++ linux-2.6.25-rc5-mm1/arch/mips/Kconfig	2008-03-31 13:14:28.028403612 -0700
@@ -2019,6 +2019,13 @@ config I8253
 config ZONE_DMA32
 	bool
 
+#
+# Used to override gas symbol setup in kernel/bounds.c.
+#
+config ASM_SYMBOL_PREFIX
+	string
+	default "@@@#define "
+
 source "drivers/pcmcia/Kconfig"
 
 source "drivers/pci/hotplug/Kconfig"
Index: linux-2.6.25-rc5-mm1/kernel/bounds.c
===================================================================
--- linux-2.6.25-rc5-mm1.orig/kernel/bounds.c	2008-03-31 13:14:26.904383870 -0700
+++ linux-2.6.25-rc5-mm1/kernel/bounds.c	2008-03-31 13:14:28.028403612 -0700
@@ -9,8 +9,17 @@
 #include <linux/page-flags.h>
 #include <linux/mmzone.h>
 
+#ifdef CONFIG_ASM_SYMBOL_PREFIX
+#define PREFIX CONFIG_ASM_SYMBOL_PREFIX
+#else
+/*
+ * Standard gas way of defining an asm symbol
+ */
+#define PREFIX "->"
+#endif
+
 #define DEFINE(sym, val) \
-	asm volatile("\n->" #sym " %0 " #val : : "i" (val))
+	asm volatile("\n" PREFIX #sym " %0 " : : "i" (val))
 
 #define BLANK() asm volatile("\n->" : :)
 

  reply	other threads:[~2008-04-02 17:36 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-02  4:32 2.6.25-rc8-mm1 Andrew Morton
2008-04-02  5:40 ` 2.6.25-rc8-mm1 Dmitri Vorobiev
2008-04-02  6:03   ` 2.6.25-rc8-mm1 Andrew Morton
2008-04-02 17:33     ` Christoph Lameter [this message]
2008-04-02 18:29       ` 2.6.25-rc8-mm1 (mips build failure) Andrew Morton
2008-04-02 18:33         ` Christoph Lameter
2008-04-02 19:06           ` Sam Ravnborg
2008-04-03 16:02             ` Ralf Baechle
2008-04-03 22:17               ` Christoph Lameter
2008-04-03 23:26                 ` Dmitri Vorobiev
2008-04-04 10:24                 ` Ralf Baechle
2008-04-04 17:36                   ` Christoph Lameter
2008-04-04 17:50                     ` Christoph Lameter
2008-04-02  6:04 ` 2.6.25-rc8-mm1 Valdis.Kletnieks
2008-04-02  6:15   ` 2.6.25-rc8-mm1 Andrew Morton
2008-04-02  6:25 ` [BUG] 2.6.25-rc8-mm1 kernel panic while bootup on powerpc Kamalesh Babulal
2008-04-02  6:39   ` Andrew Morton
2008-04-02  7:08     ` Kamalesh Babulal
2008-04-02  7:17       ` Michael Ellerman
2008-04-02 17:09         ` Kamalesh Babulal
2008-04-02 18:15           ` Badari Pulavarty
2008-04-02 19:22         ` Badari Pulavarty
2008-04-02 21:57           ` Yinghai Lu
2008-04-02 22:24           ` Yinghai Lu
2008-04-04  9:24     ` Andy Whitcroft
2008-04-02  9:02 ` [BUILD_FAILURE] 2.6.25-rc8-mm1 build failure on x86_64 with randconfig Kamalesh Babulal
2008-04-02 10:49 ` 2.6.25-rc8-mm1 Miles Lane
2008-04-02 11:08   ` 2.6.25-rc8-mm1 Valdis.Kletnieks
2008-04-02 16:58   ` 2.6.25-rc8-mm1 Chatre, Reinette
2008-04-02 19:15     ` 2.6.25-rc8-mm1 Valdis.Kletnieks
2008-04-02 16:20 ` 2.6.25-rc8-mm1 sparc64 build problem: size of array 'type name' is negative Mariusz Kozlowski
2008-04-02 16:30   ` Andrew Morton
2008-04-02 19:12 ` 2.6.25-rc8-mm1 - BUG in fs/jbd/transaction.c Valdis.Kletnieks
2008-04-02 19:27   ` Josef Bacik
2008-04-02 19:39     ` Andrew Morton
2008-04-02 19:41       ` Josef Bacik
2008-04-03 18:18       ` Stephen Smalley
2008-04-03 23:02         ` James Morris
2008-04-04 12:46           ` Stephen Smalley
2008-04-06 23:54             ` James Morris
2008-04-04 10:15         ` Jan Kara
2008-04-04 12:53           ` 2.6.25-rc8-mm1 - BUG in fs/jbd/transaction.c' Josef Bacik
2008-04-03 18:25     ` 2.6.25-rc8-mm1 - BUG in fs/jbd/transaction.c Stephen Smalley
2008-04-02 19:30   ` Andrew Morton
2008-04-03  8:57     ` Jan Kara
2008-04-03 12:11 ` 2.6.25-rc8-mm1 Dave Airlie
2008-04-03 16:59   ` 2.6.25-rc8-mm1 Andrew Morton
2008-04-03 23:08 ` 2.6.25-rc8-mm1: Intel SATA boot failure Tilman Schmidt
2008-04-03 23:17   ` Andrew Morton
2008-04-09 14:29     ` Tilman Schmidt
2008-04-14  0:28     ` Tilman Schmidt
2008-04-14  2:05       ` Andrew Morton
2008-04-15 23:33       ` Tilman Schmidt
2008-04-04 20:16 ` usb unbind/bind => WARNING at fs/sysfs/dir.c [Was: 2.6.25-rc8-mm1] Jiri Slaby
2008-04-04 20:51   ` Greg KH
2008-04-04 21:23     ` Alan Stern
2008-04-05  3:46       ` Alan Stern
2008-04-05  4:37         ` Greg KH
2008-04-05 14:16           ` Alan Stern
2008-04-05  8:17         ` Jiri Slaby
2008-04-07  6:21 ` 2.6.25-rc8-mm1 - BUG: scheduling while atomic: swapper/0/0xffffffff Valdis.Kletnieks
2008-04-07  6:48   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0804021031480.26938@schroedinger.engr.sgi.com \
    --to=clameter@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=dmitri.vorobiev@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®