From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758840AbYDDRjg (ORCPT ); Fri, 4 Apr 2008 13:39:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752909AbYDDRj0 (ORCPT ); Fri, 4 Apr 2008 13:39:26 -0400 Received: from relay2.sgi.com ([192.48.171.30]:58541 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751167AbYDDRjZ (ORCPT ); Fri, 4 Apr 2008 13:39:25 -0400 Date: Fri, 4 Apr 2008 10:36:41 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Ralf Baechle cc: Sam Ravnborg , Andrew Morton , dmitri.vorobiev@gmail.com, linux-kernel@vger.kernel.org Subject: Re: 2.6.25-rc8-mm1 (mips build failure) In-Reply-To: <20080404102407.GA25892@linux-mips.org> Message-ID: References: <20080401213214.8fbb6d6b.akpm@linux-foundation.org> <47F31C46.9000503@gmail.com> <20080401230322.331c50f4.akpm@linux-foundation.org> <20080402112907.76e1c554.akpm@linux-foundation.org> <20080402190623.GA23651@uranus.ravnborg.org> <20080403160230.GA17771@linux-mips.org> <20080404102407.GA25892@linux-mips.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Apr 2008, Ralf Baechle wrote: > Almost. It compiles into a usable header but breaks the text() macro > which is used to emit a commit (actually any string literal) into the > output: The text macro still emits the same text. Nothing is changed. Why does this break anything? > With your patch nothing will be emited. The existing non-MIPS sed > expression in Kbuild doesn't allow for that which is why I added the > handling of @@@-prefixed strings to the sed expression. And once that > is there the remaining asm-offset.c change is no longer needed. Why would kbuild have to handle comments?