From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758752AbYDNBle (ORCPT ); Sun, 13 Apr 2008 21:41:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753745AbYDNBl1 (ORCPT ); Sun, 13 Apr 2008 21:41:27 -0400 Received: from x35.xmailserver.org ([64.71.152.41]:46890 "EHLO x35.xmailserver.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753660AbYDNBl0 (ORCPT ); Sun, 13 Apr 2008 21:41:26 -0400 X-AuthUser: davidel@xmailserver.org Date: Sun, 13 Apr 2008 18:41:24 -0700 (PDT) From: Davide Libenzi X-X-Sender: davide@alien.or.mcafeemobile.com To: Arnd Bergmann cc: Linux Kernel Mailing List , Linus Torvalds , Andrew Morton , Al Viro Subject: Re: [patch] F_GETPATH for linux In-Reply-To: <200804140300.05719.arnd@arndb.de> Message-ID: References: <200804140300.05719.arnd@arndb.de> X-GPG-FINGRPRINT: CFAE 5BEE FD36 F65E E640 56FE 0974 BF23 270F 474E X-GPG-PUBLIC_KEY: http://www.xmailserver.org/davidel.asc MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Apr 2008, Arnd Bergmann wrote: > On Monday 14 April 2008, Davide Libenzi wrote: > > I was working on some bsd/linux compatibility code, and I noticed that we > > do not have F_GETPATH. I know we can readlink /proc/PID/fd/FD (that is > > what I'm doing now, under #ifdef), but I gave a patch a shot anyway. > > Here it is, building but untested ... > > I reviewed the code path for compat_sys_fcntl{,64} for this patch, looks > good in that respect. > > > +error: > > + free_page((unsigned long) buf); > > + return size; > > +} > > +EXPORT_SYMBOL(fcntl_getpath); > > + > > Procfs cannot be a module, and there are no other users of this function, > so why do you export it? Springtime export fever? :) I dropped the export. I'll repost as soon as I've five minutes to reboot my box (to test the thing a little). - Davide