From: Davide Libenzi <davidel@xmailserver.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@ftp.linux.org.uk>
Subject: Re: [patch] F_GETPATH for linux
Date: Mon, 14 Apr 2008 10:34:16 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0804141030060.20665@alien.or.mcafeemobile.com> (raw)
In-Reply-To: <20080414061958.GA21202@infradead.org>
On Mon, 14 Apr 2008, Christoph Hellwig wrote:
> On Sun, Apr 13, 2008 at 03:00:53PM -0700, Davide Libenzi wrote:
> > I was working on some bsd/linux compatibility code, and I noticed that we
> > do not have F_GETPATH. I know we can readlink /proc/PID/fd/FD (that is
> > what I'm doing now, under #ifdef), but I gave a patch a shot anyway.
> > Here it is, building but untested ...
>
> Adding a duplicated API like this is rather pointless. Especially as
> the readlink is easier and makes more sense.
As I said, we can do it in the other way. I struck this one when trying to
work out (read port) some BSD code to Linux. IMO, given that the patch
does virtually only add an F_GETPATH define in fcntl.h, and a case in the
fcntl switch, it may be worth considering.
- Davide
prev parent reply other threads:[~2008-04-14 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-13 22:00 Davide Libenzi
2008-04-14 1:00 ` Arnd Bergmann
2008-04-14 1:41 ` Davide Libenzi
2008-04-14 5:34 ` Michael Kerrisk
2008-04-14 17:42 ` Davide Libenzi
2008-04-14 6:19 ` Christoph Hellwig
2008-04-14 11:44 ` H. Peter Anvin
2008-04-14 14:48 ` Linus Torvalds
2008-04-14 17:34 ` Davide Libenzi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0804141030060.20665@alien.or.mcafeemobile.com \
--to=davidel@xmailserver.org \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®