Re: [PATCH] eventfd, signalfd, timerfd, epoll_create w/flags

[Davide Libenzi <davidel@xmailserver.org>]

On Sun, 27 Apr 2008, Ulrich Drepper wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Davide Libenzi wrote:
> 
> > Ok, I asked this myself for about ten minutes, than I gave up. But why 
> > sys_epoll_createp() instead of sys_epoll_create2()? There MUST be a reason 
> > to deviate from the standard of all the other ones...
> 
> I used the number at the end for syscalls which aren't visible at
> userlevel.  There they are useful indicating the number of arguments.
> At userlevel I personally find it less than optimal but I'd have no
> problem changing it to epoll_create2.

I think that an ending '2' at least has the logic behind of telling the 
number of parameters. A 'p' really doesn't say anything.
So it's either gonna be something like epoll_create_flags() or 
epoll_create2(). And between the two, I'd personally pick the latter.



- Davide