From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] video: fix SOC_CAMERA_MT9M001 build bug
Date: Mon, 28 Apr 2008 22:17:04 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0804282215470.11449@axis700.grange> (raw)
In-Reply-To: <20080428201105.GD15840@elte.hu>
On Mon, 28 Apr 2008, Ingo Molnar wrote:
>
> * Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
>
> > > as you can see it from the build log above, the compiler disagrees
> > > with you on whether the driver depends on I2C. I'm just the
> > > messenger :)
> >
> > Very sorry, but I don't see it. What I see above, is that mt9m001 and
> > mt9v022 cannot be compiled - as I said, _they_ need i2c. And I don't
> > see a single line for soc_camera.c. SOC_CAMERA is a generic API, it
> > shouldn't have any hardware dependencies at all. Whereas mt9v022 and
> > mt9m001 are 2 specific i2c cameras.
>
> sorry, you are right. Mind doing the right patch as you know this code
> much better than i do?
Ok, will do, although, the fix is just to duplicate your patch and move it
from under SOC_CAMERA to MT9V022 and MT9M001. Thanks for reporting.
Guennadi
---
Guennadi Liakhovetski
next prev parent reply other threads:[~2008-04-28 20:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 12:00 Ingo Molnar
2008-04-28 17:46 ` Guennadi Liakhovetski
2008-04-28 19:31 ` Ingo Molnar
2008-04-28 19:41 ` Guennadi Liakhovetski
2008-04-28 20:11 ` Ingo Molnar
2008-04-28 20:17 ` Guennadi Liakhovetski [this message]
2008-04-29 11:48 ` Guennadi Liakhovetski
2008-04-29 20:03 ` Mauro Carvalho Chehab
2008-04-30 9:35 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0804282215470.11449@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®