From: Roman Zippel <zippel@linux-m68k.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Stephen Hemminger <shemminger@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch, -git] input: CONFIG_INPUT_APANEL build fix
Date: Wed, 30 Apr 2008 22:56:05 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0804302232060.30555@scrub.home> (raw)
In-Reply-To: <20080430202013.GB14164@elte.hu>
Hi,
On Wed, 30 Apr 2008, Ingo Molnar wrote:
> > Thank you Ingo. Isn't this a Kconfig issue though? I know that Roman
> > is not willing to fix SELECT to evaluate the whole dependency chain,
> > but in this case it is "depens on" that does not evaluate properly...
>
> yes and no. It can be fixed in Kconfig but i'm not going to flame yet
> another person about long-existing unfixed infrastructure bugs ;-)
You don't have to, because this simply is no infrastructure bug...
Don't blame Kconfig for abusing select for something it was never
intendend for. There is no bug!
In this case there is now a mixture of depends and selects on leds. First
decide whether led support should be automatically included or the driver
is only available when led support is enabled. In the first case it's
probably better to create LEDS_SUPPORT, which then again selects
everything necessary.
bye, Roman
next prev parent reply other threads:[~2008-04-30 20:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 18:54 Ingo Molnar
2008-04-30 19:04 ` Dmitry Torokhov
2008-04-30 20:20 ` Ingo Molnar
2008-04-30 20:56 ` Roman Zippel [this message]
2008-04-30 22:21 ` Dmitry Torokhov
2008-04-30 21:00 ` Dmitry Torokhov
2008-04-30 21:20 ` Ingo Molnar
2008-04-30 22:26 ` Dmitry Torokhov
2008-04-30 22:38 ` Ingo Molnar
2008-04-30 22:47 ` Dmitry Torokhov
2008-05-01 0:51 ` Roman Zippel
2008-05-01 2:36 ` Dmitry Torokhov
2008-05-01 6:25 ` Jan Engelhardt
2008-05-01 1:29 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0804302232060.30555@scrub.home \
--to=zippel@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®