From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934112AbYEFWml (ORCPT ); Tue, 6 May 2008 18:42:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933452AbYEFWl4 (ORCPT ); Tue, 6 May 2008 18:41:56 -0400 Received: from x35.xmailserver.org ([64.71.152.41]:38032 "EHLO x35.xmailserver.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932846AbYEFWly (ORCPT ); Tue, 6 May 2008 18:41:54 -0400 X-AuthUser: davidel@xmailserver.org Date: Tue, 6 May 2008 15:41:51 -0700 (PDT) From: Davide Libenzi X-X-Sender: davide@alien.or.mcafeemobile.com To: Matthew Helsley cc: Ulrich Drepper , Linux Kernel Mailing List , netdev@vger.kernel.org, Andrew Morton , mtk.manpages@gmail.com, Linus Torvalds Subject: Re: [PATCH 08/18] flag parameters: epoll_create In-Reply-To: <1210107990.7323.347.camel@localhost.localdomain> Message-ID: References: <200805050342.m453gk49029835@devserv.devel.redhat.com> <1210107990.7323.347.camel@localhost.localdomain> X-GPG-FINGRPRINT: CFAE 5BEE FD36 F65E E640 56FE 0974 BF23 270F 474E X-GPG-PUBLIC_KEY: http://www.xmailserver.org/davidel.asc MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 6 May 2008, Matthew Helsley wrote: > > On Sun, 2008-05-04 at 23:42 -0400, Ulrich Drepper wrote: > > This patch adds the new epoll_create2 syscall. It extends the old epoll_create > > syscall by one parameter which is meant to hold a flag value. In this > > patch the only flag support is EPOLL_CLOEXEC which causes the close-on-exec > > flag for the returned file descriptor to be set. > > Davide, Ulrich, > > A minor question: Why did you choose to pass the seemingly useless > "size" parameter into the new epoll_create2 system call? I did some > googling for previous threads with this series and couldn't find a > discussion on why you chose to keep it. The very first implementations were using an hash, and that was a size hint. - Davide