From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933966AbYEFWpj (ORCPT ); Tue, 6 May 2008 18:45:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761021AbYEFWpY (ORCPT ); Tue, 6 May 2008 18:45:24 -0400 Received: from x35.xmailserver.org ([64.71.152.41]:38040 "EHLO x35.xmailserver.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754956AbYEFWpW (ORCPT ); Tue, 6 May 2008 18:45:22 -0400 X-AuthUser: davidel@xmailserver.org Date: Tue, 6 May 2008 15:45:21 -0700 (PDT) From: Davide Libenzi X-X-Sender: davide@alien.or.mcafeemobile.com To: Ulrich Drepper cc: Linux Kernel Mailing List , netdev@vger.kernel.org, Andrew Morton , mtk.manpages@gmail.com, Linus Torvalds Subject: Re: [PATCH 15/18] flag parameters: NONBLOCK in timerfd_create In-Reply-To: <200805062118.m46LI72i004086@devserv.devel.redhat.com> Message-ID: References: <200805062118.m46LI72i004086@devserv.devel.redhat.com> X-GPG-FINGRPRINT: CFAE 5BEE FD36 F65E E640 56FE 0974 BF23 270F 474E X-GPG-PUBLIC_KEY: http://www.xmailserver.org/davidel.asc MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 6 May 2008, Ulrich Drepper wrote: > diff --git a/fs/timerfd.c b/fs/timerfd.c > index c6ef5e3..75d44ef 100644 > --- a/fs/timerfd.c > +++ b/fs/timerfd.c > @@ -184,7 +184,7 @@ asmlinkage long sys_timerfd_create(int clockid, int flags) > int ufd; > struct timerfd_ctx *ctx; > > - if (flags & ~TFD_CLOEXEC) > + if (flags & ~(TFD_CLOEXEC | TFD_NONBLOCK)) > return -EINVAL; > if (clockid != CLOCK_MONOTONIC && > clockid != CLOCK_REALTIME) > @@ -199,7 +199,7 @@ asmlinkage long sys_timerfd_create(int clockid, int flags) > hrtimer_init(&ctx->tmr, clockid, HRTIMER_MODE_ABS); > > ufd = anon_inode_getfd("[timerfd]", &timerfd_fops, ctx, > - flags & O_CLOEXEC); > + flags & (O_CLOEXEC | O_NONBLOCK)); > if (ufd < 0) > kfree(ctx); This is perfectly fine for me. Since the flags space for these new syscalls is almost empty, it makes perfect sense to just map them to the original O_* flags. Acked-by: Davide Libenzi (for the whole serie) - Davide