From: Christoph Lameter <clameter@sgi.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Russ Anderson <rja@sgi.com>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH 0/3] ia64: Migrate data off physical pages with correctable errors v3
Date: Fri, 9 May 2008 09:38:25 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0805090935520.18195@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <alpine.LFD.1.10.0805090817280.3142@woody.linux-foundation.org>
On Fri, 9 May 2008, Linus Torvalds wrote:
> So I haven't looked at this a lot, but it strikes me that it look to be
> much simple if you were to just increment the page count instead of
> playing games in mm/page_alloc.c.
We are taking a refcount when isolating the page from the LRU. The
problem is that the migration code attempts to free the page. That code
could be changed to do something else instead like putting the page on the
bad list.
> I'm also not really seeing why this triggers on lru_cache_add(), since
> that should only happen to new pages anyway. Who does lru_cache_add() on
> old pages?
Migration code does the adding back to the LRU when migration is complete.
So he hooked into that I guess.
next prev parent reply other threads:[~2008-05-09 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-09 15:09 Russ Anderson
2008-05-09 15:21 ` Linus Torvalds
2008-05-09 16:27 ` Russ Anderson
2008-05-09 16:38 ` Christoph Lameter [this message]
2008-05-13 21:32 ` Russ Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0805090935520.18195@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rja@sgi.com \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®