From: Christoph Lameter <clameter@sgi.com>
To: Russ Anderson <rja@sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH 3/3] ia64: Call migration code on correctable errors v3
Date: Fri, 9 May 2008 14:03:19 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0805091358160.20375@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20080509151135.GD16523@sgi.com>
On Fri, 9 May 2008, Russ Anderson wrote:
> + local_irq_save(irq_flags);
The page migration functions expect to be called in non atomic contexts
since they use things like lock_page(). Can you just drop the irq disable?
The spinlock should not be there either. Page migration serialize via
the LRU. Pages that are to be migrated have to be taken off the LRU
first. There is no danger of two threads trying to migrate the same
page because the second one will not be able to take it off the LRU
anymore.
next prev parent reply other threads:[~2008-05-09 21:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-09 15:11 Russ Anderson
2008-05-09 20:52 ` Andrew Morton
2008-05-09 21:03 ` Christoph Lameter [this message]
2008-05-09 21:07 ` Russ Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0805091358160.20375@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rja@sgi.com \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®